This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Set bfd field in target_section
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Aleksandar Ristovski <aristovski at qnx dot com>, gdb-patches at sources dot redhat dot com
- Date: Tue, 28 Jul 2009 15:34:41 +0100
- Subject: Re: [patch] Set bfd field in target_section
- References: <h4n1ui$nt3$1@ger.gmane.org>
On Tuesday 28 July 2009 15:28:33, Aleksandar Ristovski wrote:
> Hello,
>
> I believe this is related to Pedro's patch from 03-Jun-09. I
> didn't see where we set target_section.bfd field - maybe I
> am overlooking something, but in bfd-target, in function
> target_bfd_xclose we will call bfd_close
> (table->sections->bfd); bfd_close doesn't like NULL argument.
>
> Am I missing something, or is this (the patch) missing?
Doesn't add_to_section_table set the bfd in each new
target section?
>
> Patch attached.
>
> Thanks,
>
> --
> Aleksandar Ristovski
> QNX Software Systems
>
> ChangeLog:
>
> * exec.c (build_section_table): Setup section_table bfd field.
> exec_c-20090728.diff
> Index: gdb/exec.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/exec.c,v
> retrieving revision 1.90
> diff -u -p -r1.90 exec.c
> --- gdb/exec.c??2 Jul 2009 17:21:06 -0000???????1.90
> +++ gdb/exec.c??28 Jul 2009 14:21:09 -0000
> @@ -441,6 +441,7 @@ build_section_table (struct bfd *some_bf
> ? ?bfd_map_over_sections (some_bfd, add_to_section_table, (char *) end);
> ? ?if (*end > *start + count)
> ? ? ?internal_error (__FILE__, __LINE__, _("failed internal consistency check"));
> + ?(*start)->bfd = (*end)->bfd = some_bfd;
> ? ?/* We could realloc the table, but it probably loses for most files. ?*/
> ? ?return 0;
> ?}
--
Pedro Alves