This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Speed up dwarf2_frame_find_fde

On Wed, Jul 22, 2009 at 1:54 AM, Andreas Schwab<schwab@redhat.com> wrote:

>> +  return cie_pointer - cie->cie_pointer;
>
> This can overflow.

Fixed in the attached patch.

Thanks,
-- 
Paul Pluzhnikov

2009-07-22  Paul Pluzhnikov  <ppluzhnikov@google.com>

       * dwarf2-frame.c (struct dwarf2_cie): Remove 'next'.
       (struct dwarf2_cie_table): New.
       (struct dwarf2_fde): Remove 'next'.
       (struct dwarf2_fde_table): New.
       (struct comp_unit): Remove 'cie'.
       (bsearch_cie_cmp, bsearch_fde_cmp): New function.
       (find_cie, dwarf2_frame_find_fde): Use bsearch.
       (add_cie, add_fde): Use array instead of linked list.
       (decode_frame_entry, decode_frame_entry_1): New parameters.
       (qsort_fde_cmp): New function.
       (dwarf2_build_frame_info): Adjust.

Attachment: gdb-find_fde-20090722.txt
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]