This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Wed, Jul 22, 2009 at 9:32 AM, Pedro Alves<pedro@codesourcery.com> wrote: > In the OBJF_USERLOADED case, you rebuild the map when you don't > really need to. I think it's pretty clear that what I really need is a new 'remove_objfile' kind of observer. > You're also likely breaking xcoffsolib.c and the vmap code in exec.c, as > it calls free_objfile without going through observers. This would be handled by the 'remove_objfile' observer, I think. > Given the new_objfile observer, do we still need the exec_changed and > solib observers? No, I've removed that (new patch attached). > Please look around and check that objfile->section_offsets or > obj_section_offset isn't being used as an lvalue somewhere where > the map cache isn't being flushed. I think new_objfile/remove_objfile will take care of any of these. Should I revert the find_pc_section patch, work up remove_objfile observer patch, then re-apply find_pc_section patch once it's in better shape? Thanks, -- Paul Pluzhnikov 2009-07-22 Paul Pluzhnikov <ppluzhnikov@google.com> * objfiles.c (objfile_relocate): Must rebuild section map. (set_objfiles_updated_on_exe_change): Remove. (set_objfiles_updated_on_new_objfile): New observer. (_initialize_objfiles): Adjust.
Attachment:
gdb-find_pc_section-20090722-2.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |