This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/RFC Prec] Add Linux AMD64 process record support second version, (instruction set support) 1/3

Hi Hui,

I think I discovered a bug in this one.  In 64-bit mode,
the "call immediate" instruction is not correctly logging
the pushed return address.  It's only saving 4 bytes.

Please tell me what you think of this patch to your patch?

Michael

--- i386-tdep.c 2009-07-19 17:51:58.000300000 -0700
+++ tmp/i386-tdep.c     2009-07-19 17:51:51.000907000 -0700
@@ -4563,6 +4563,8 @@ reswitch:

       /* call im */
     case 0xe8:
+      if (ir.regmap[X86_RECORD_R8_REGNUM] && ir.dflag)
+        ir.dflag = 2;
       if (i386_record_push (&ir, 1 << (ir.dflag + 1)))
         return -1;
       break;

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]