This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 4/8] Types GC [varobj_list to all_root_varobjs]
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Vladimir Prus <vladimir at codesourcery dot com>
- Date: Thu, 2 Jul 2009 10:37:05 +0200
- Subject: Re: [patch 4/8] Types GC [varobj_list to all_root_varobjs]
- References: <20090525080233.GD13323@host0.dyn.jankratochvil.net> <m3ljo1i125.fsf@fleche.redhat.com>
On Tue, 09 Jun 2009 22:50:42 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
>
> Jan> I find the callback based iterator easier to use,
[...]
> It seems reasonable to me, though it would be nice to have Volodya's
> approval.
Is it OK to check it in, Vladimir? The patch would go in unchanged:
http://sourceware.org/ml/gdb-patches/2009-05/msg00547.html
Regression re-tested now on {x86_64,i686}-fedora-linux-gnu.
> Jan> in fact there were bugs due to the
> Jan> current calling semantics (`floating' lockup, memory leaks).
>
> Details on the bugs that this fixes would be nice.
> A test case would also be nice, assuming these are testable.
The `floating' lockup will get fixed by a later patch using this new
all_root_varobjs function. A testcase for it was in a now-obsolete patch:
[patch] Fix gdb.mi hang on floating VAROBJs
http://sourceware.org/ml/gdb-patches/2009-05/msg00433.html
This patch itself still does not fix it.
The (small) memory caused by the current semantics you fixed by:
RFA: fix PR 9350
http://sourceware.org/ml/gdb-patches/2009-01/threads.html#00066
7002b113b9e2afed981d3eb9d4157c98a3a3c447
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/varobj.c.diff?cvsroot=src&r1=1.121&r2=1.122
Thanks,
Jan