This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Remove unimplemented MI commands [Re: Learn function name by its address]
- From: Vladimir Prus <vladimir at codesourcery dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Sun, 28 Jun 2009 10:43:43 +0400
- Subject: Re: [patch] Remove unimplemented MI commands [Re: Learn function name by its address]
- References: <8ac60eac0906271144k61bbb6e3sc092d2780dc4192e@mail.gmail.com>
Paul Pluzhnikov wrote:
> On Fri, Jun 26, 2009 at 3:41 PM, Joel Brobecker<brobecker@adacore.com> wrote:
>
>>> I tend to think that if nobody has implemented these in $X years, then
>>> nobody ever will. ÂBut then, I'm generally also in the "never comment
>>> out code, just delete it" camp.
>>
>> So am I. The code is still around, just in CVS instead of inside
>> a comment. ÂLeaving it commented out just creates more clutter that
>> tends to stay rather than being fixed. So I really favor deleting.
>
> Ok, patch attached.
The code patch is fine. Although at least one of those commands is likely
to be implemented within a year (-break-commands), there's no point to
keep it recognized-but-not-implemented for now.
Thanks,
Volodya