This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PING][RFA-v2] Fix troubles with watchpoints in DJGPP
- From: Pedro Alves <pedro at codesourcery dot com>
- To: "Pierre Muller" <muller at ics dot u-strasbg dot fr>
- Cc: gdb-patches at sourceware dot org, "'Eli Zaretskii'" <eliz at gnu dot org>
- Date: Tue, 16 Jun 2009 23:59:43 +0100
- Subject: Re: [PING][RFA-v2] Fix troubles with watchpoints in DJGPP
- References: <001401c9de9f$928b9f80$b7a2de80$@u-strasbg.fr> <006f01c9e854$7295da10$57c18e30$@u-strasbg.fr> <000001c9eed3$0e883f10$2b98bd30$@u-strasbg.fr>
On Tuesday 16 June 2009 23:37:38, Pierre Muller wrote:
>
> No one reacted to this second version of my patch...
My reaction was that the patch looked OK,
but please could you expand the comment some more to
explain a bit better why we need this:
+ /* Call breakpoint_re_set to update watchpoints types. */
+ breakpoint_re_set ();
This almost looks like:
+ /* Increment variable by one. */
+ i++;
;-)
breakpoint_re_set is very likely to be something we
will be wanting to split further, make smarter and/or
eliminate, so having its non-obvious uses nicely described
is a good thing, IMO.
> I still have other hardware watchpoint related problems
> that need to be discussed, but this one is really a small patch,
> no ?
--
Pedro Alves