This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Error reporting during insert_breakpoints
On Wednesday 03 June 2009 22:46:44, Pedro Alves wrote:
> > @@ -1223,10 +1223,10 @@ Note: automatically using hardware break
> > ? ? ? ? ? ? ? else
> > ? ? ? ? ? ? ? ? {
> > ? ? ? ? ? ? ? ? ? fprintf_unfiltered (tmp_error_stream,
> > - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? "Cannot insert breakpoint %d.\n",
> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? "Cannot insert breakpoint %d",
> > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? bpt->owner->number);
> > ? ? ? ? ? ? ? ? ? fprintf_filtered (tmp_error_stream,
> > - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? "Error accessing memory address ");
> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? " at memory address ");
> > ? ? ? ? ? ? ? ? ? fputs_filtered (paddress (bpt->address), tmp_error_stream);
> > ? ? ? ? ? ? ? ? ? fprintf_filtered (tmp_error_stream, ": %s.\n",
> > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? safe_strerror (val));
>
> I'm not objecting to the change, but, honestly, I don't see where
> the assumption was, or where it is being removed?
Oh, silly me. It's the s/accessing/at/. Ignore me there. BTW, since
you're touching this, how about merging all those fprintf calls
into a single call, and wrapping the user visible string in _() for
translation?
--
Pedro Alves