This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] trailing backslash in top-level Makefile


* Ralf Wildenhues wrote on Tue, Jun 02, 2009 at 08:00:21PM CEST:
> 	* Makefile.tpl: Avoid a trailing backslash.
> 	* Makefile.in: Regenerate.

> --- a/Makefile.tpl
> +++ b/Makefile.tpl
> @@ -628,8 +628,9 @@ all:
>  	  $(MAKE) $(RECURSE_FLAGS_TO_PASS) all-host all-target \
>  @if gcc-bootstrap
>  	    ; \
> -	fi
> +	fi \
>  @endif gcc-bootstrap
> +	&& :
>  
>  .PHONY: all-build
>  [+ FOR build_modules +]

This patch seems to fix the issue, and as such: OK to apply to GCC and
src?

All my testing has been casual rather than following the rules, but I
think I've tried out all failure cases in GCC and src.  Bummer there is
no exact opposite of the '@if gcc-bootstrap' switch yet (neither it nor
gcc-no-bootstrap are true for a binutils-only build), it would make for
a more readable rule.  Hmm, maybe we should add one later.

Cheers,
Ralf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]