This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [obv] Fix Modula2 MAX_FUNC typo
- From: Gaius Mulley <gaius at glam dot ac dot uk>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 23 May 2009 10:55:11 +0100
- Subject: Re: [obv] Fix Modula2 MAX_FUNC typo
- References: <20090521144029.GA29101@host0.dyn.jankratochvil.net>
Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> Hi,
>
> unaware of modula2, no regressions, it looks to me as an apparent typo. Still
> the result of this code is IMO currently not in use at all.
>
>
> Regards,
> Jan
many thanks Jan, for spotting this - yes it looks as if this component
of the gdb modula2 support is not used much. I know of people using
gdb and modula2 in general though :-). And you're right there needs
to be some regression test code and written (note to self)
regards,
Gaius
> http://sourceware.org/ml/gdb-cvs/2009-05/msg00136.html
>
> 2009-05-21 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * m2-exp.y (MAX_FUNC): Fix trailing UNOP_MAX.
>
> --- src/gdb/m2-exp.y 2009/03/18 08:51:11 1.26
> +++ src/gdb/m2-exp.y 2009/05/21 14:38:20 1.27
> @@ -265,7 +265,7 @@
> exp : MAX_FUNC '(' type ')'
> { write_exp_elt_opcode (UNOP_MAX);
> write_exp_elt_type ($3);
> - write_exp_elt_opcode (UNOP_MIN); }
> + write_exp_elt_opcode (UNOP_MAX); }
> ;
>
> exp : FLOAT_FUNC '(' exp ')'