This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/Windows] Remove ADD_SHARED_SYMBOL_FILES macro
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pierre Muller <muller at ics dot u-strasbg dot fr>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 22 May 2009 08:30:42 -0700
- Subject: Re: [RFA/Windows] Remove ADD_SHARED_SYMBOL_FILES macro
- References: <003d01c9d4e2$987399a0$c95acce0$@u-strasbg.fr>
> 2009-05-15 Pierre Muller <muller@ics.u-strasbg.fr>
>
> * symfile.c (add_shared_symbol_files_command): Remove
> prototype and function.
> (_initialize _symfile): Move "add-shared-symbol-files"
> command and "assf" alias.
This part is fine.
> * windows-nat.c (_initialize_windows_nat): to here.
This part, however, is unnecessary, I think. There is already a command
called dll-symbols that calls the very same function (dll_symbol_command).
My suggestion would be to delete the add-shared-symbols-files entirely,
or to make it a deprecated alias to dll-symbols.
Chris, what do you think?
> * config/i386/cygwin.mh: Remove NAT_FILE.
> * config/i386/mingw.mh: Remove NAT_FILE.
> * config/i386/mingw64.mh: Remove NAT_FILE.
> * config/i386/nm-cygwin.h: Remove file.
> * config/i386/nm-cygwin64.h: Remove file.
This part is fine.
Thanks for doing this,
--
Joel