This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [Prec/RFA] fix build error of prec in cygwin
On Fri, May 22, 2009 at 10:12:01AM +0800, Hui Zhu wrote:
>On Fri, May 22, 2009 at 08:46, Christopher Faylor
><cgf-use-the-mailinglist-please@sourceware.org> wrote:
>> On Fri, May 22, 2009 at 07:14:48AM +0800, Hui Zhu wrote:
>>>On Fri, May 22, 2009 at 01:38, Christopher Faylor ?wrote:
>>>> On Fri, May 22, 2009 at 12:43:07AM +0800, Hui Zhu wrote:
>>>>>Thanks for you help me review my patch. ?Could you give me some help
>>>>>with it? ?Actually, try something with cygwin still a very hard thing
>>>>>for me. ?I just can use it in a notebook of other guy. ?And I had
>>>>>return it. ?Maybe you can make a patch for this bug. ?That will be very
>>>>>great for me.
>>>>
>>>>I don't see why this has anything to do with Cygwin. ??We're talking
>>>>about general principles here. ?If you know C, which you obviously do,
>>>>then I don't really understand why this needs a lot of explanation.
>>>>Look at the places where you're using coercion with a format string and
>>>>just use the right format specifier instead.
>>>
>>>Because the patch must be work OK with cygwin. ?Even if for the format.
>>>I think you must have a lot of good idea with it. ?We need your help.
>>>That is very great for me. ?Thanks a lot.
>>
>> No need to thank me yet. ?I'll be happy to review your change when you
>> make the simple changes that I requested. ?You can hold off thanking me
>> until then.
>
>About %u and sizeof, if without (int). It's OK with cygwin. But it
>cannot work OK with amd64.
>It will get:
>../../src/gdb/linux-record.c: In function ?record_linux_system_call?:
>../../src/gdb/linux-record.c:551: warning: format ?%u? expects type
>?unsigned int?, but argument 4 has type ?long unsigned int?
>Could you give me some help with it?
"%zu"
cgf