This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[rfc] Minor cleanup to pascal_val_print
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: gdb-patches at sourceware dot org, muller at ics dot u-strasbg dot fr
- Date: Thu, 14 May 2009 13:34:24 +0200 (CEST)
- Subject: [rfc] Minor cleanup to pascal_val_print
Hello,
p-valprint.c uses "extract_unsigned_integer" to extract the value of a
reference in order to print it, explicitly using gdbarch_ptr_bit as
length. The corresponding location in the val_print routine of all
other languages (except Ada) simply uses extract_typed_address to get
at that value.
The patch below changes pascal_val_print to do the same thing, getting
rid of a current_gdbarch instance in the process.
Pierre, is there any reason why this would be wrong for Pascal?
Bye,
Ulrich
ChangeLog:
* p-valprint.c (pascal_val_print): Use extract_typed_address
to extract reference value.
Index: gdb-head/gdb/p-valprint.c
===================================================================
--- gdb-head.orig/gdb/p-valprint.c
+++ gdb-head/gdb/p-valprint.c
@@ -251,11 +251,10 @@ pascal_val_print (struct type *type, con
elttype = check_typedef (TYPE_TARGET_TYPE (type));
if (options->addressprint)
{
+ CORE_ADDR addr
+ = extract_typed_address (valaddr + embedded_offset, type);
fprintf_filtered (stream, "@");
- /* Extract the address, assume that it is unsigned. */
- fputs_filtered (paddress (
- extract_unsigned_integer (valaddr + embedded_offset,
- gdbarch_ptr_bit (current_gdbarch) / HOST_CHAR_BIT)), stream);
+ fputs_filtered (paddress (addr), stream);
if (options->deref_ref)
fputs_filtered (": ", stream);
}
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com