This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Process record and replay checked in to main trunk
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Michael Snyder <msnyder at vmware dot com>, Pierre Muller <muller at ics dot u-strasbg dot fr>, "'Hui Zhu'" <teawater at gmail dot com>
- Date: Fri, 8 May 2009 00:06:18 +0100
- Subject: Re: Process record and replay checked in to main trunk
- References: <daef60380904300059g191dfe0bu7773ee01f35892bf@mail.gmail.com> <001201c9cf62$8e2761a0$aa7624e0$@u-strasbg.fr> <4A036401.6060906@vmware.com>
On Thursday 07 May 2009 23:43:13, Michael Snyder wrote:
> Guessing it isn't implemented for 64 bit.
I don't think that's the problem here. Cygwin is 32-bit, and has 32-bit
ints.
> ../../purecvs/gdb/linux-record.c:397: warning: unsigned int format, uint32_t
> arg
> ../../purecvs/gdb/linux-record.c:629: warning: int format, uint32_t arg (arg
Better use casts, or use plongest/pulongest/hex_string where appropriate?
> Perhaps we should have a --disable-process-record config option?
> If only for a back-up plan?
I think that would be more work than fixing this properly. :-)
> ../../purecvs/gdb/linux-record.c:1636: error: `F_GETLK64' undeclared (first
> use
> in this function)
There are a bunch of RECORD_* macros defined on top of linux-record.c
to replace contants like these. E.g., RECORD_Q_GETFMT. Looks like
this case was just missed.
--
Pedro Alves