This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA] Fix memory leak in gdbserver
- From: dje at google dot com (Doug Evans)
- To: gdb-patches at sourceware dot org
- Date: Wed, 29 Apr 2009 23:38:36 -0700 (PDT)
- Subject: [RFA] Fix memory leak in gdbserver
Hi.
This fixes a memory leak in gdbserver.
Ok to check in?
2009-04-29 Doug Evans <dje@google.com>
* inferiors.c (remove_process): Fix memory leak, free process.
* linux-low.c (linux_remove_process): New function.
(linux_kill): Call it instead of remove_process.
(linux_detach, linux_wait_1): Ditto.
Index: inferiors.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/inferiors.c,v
retrieving revision 1.20
diff -u -p -r1.20 inferiors.c
--- inferiors.c 3 Apr 2009 20:15:51 -0000 1.20
+++ inferiors.c 30 Apr 2009 01:23:29 -0000
@@ -427,12 +427,17 @@ add_process (int pid, int attached)
return process;
}
+/* Remove a process from the common process list and free the memory
+ allocated for it.
+ The caller is responsible for freeing private data first. */
+
void
remove_process (struct process_info *process)
{
clear_symbol_cache (&process->symbol_cache);
free_all_breakpoints (process);
remove_inferior (&all_processes, &process->head);
+ free (process);
}
struct process_info *
Index: linux-low.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/linux-low.c,v
retrieving revision 1.97
diff -u -p -r1.97 linux-low.c
--- linux-low.c 3 Apr 2009 11:40:02 -0000 1.97
+++ linux-low.c 30 Apr 2009 06:30:01 -0000
@@ -182,6 +182,16 @@ linux_add_process (int pid, int attached
return proc;
}
+/* Remove a process from the common process list,
+ also freeing all private data. */
+
+static void
+linux_remove_process (struct process_info *process)
+{
+ free (process->private);
+ remove_process (process);
+}
+
/* Handle a GNU/Linux extended wait response. If we see a clone
event, we need to add the new LWP to our list (and not report the
trap to higher layers). */
@@ -565,7 +575,7 @@ linux_kill (int pid)
} while (lwpid > 0 && WIFSTOPPED (wstat));
delete_lwp (lwp);
- remove_process (process);
+ linux_remove_process (process);
return 0;
}
@@ -654,7 +664,7 @@ linux_detach (int pid)
delete_all_breakpoints ();
find_inferior (&all_threads, linux_detach_one_lwp, &pid);
- remove_process (process);
+ linux_remove_process (process);
return 0;
}
@@ -1273,7 +1283,7 @@ retry:
struct process_info *process = find_process_pid (pid);
delete_lwp (lwp);
- remove_process (process);
+ linux_remove_process (process);
current_inferior = NULL;