This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Bug symtab/8367] [RFA] performance improvement of lookup_partial_symtab


> > 2009-01-14  Jerome Guitton  <guitton@adacore.com>
> > 
> > 	* symtab.c (lookup_partial_symtab): When looking up an absolute path
> > 	in the partial symtabs, compare the base names before checking the
> > 	full names.

We're only 3.5 months late reviewing this patch :-(... This looks OK
to me. I verified that this cannot create behavior changes due to
find_and_open_source returning a fullname with a different basename
(for instance if the source file was actually a link to another source
file): openp only canonicalizes the directory portion of the fullname.

So I think this is reasonable. Please go ahead and commit.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]