This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Re : New language support : Vala
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: a dot kitouni at gmail dot com, gdb-patches at sourceware dot org
- Date: Tue, 14 Apr 2009 10:21:06 +0300
- Subject: Re: Re : New language support : Vala
- References: <3d6b0edb0902070607x29177016m48a40bd198b88f7e@mail.gmail.com> <m3wsc22fuv.fsf@fleche.redhat.com> <3d6b0edb0902090505m6bcb142crab53b0f860535ff4@mail.gmail.com> <3d6b0edb0902182352p7143c29clb382aa5602720463@mail.gmail.com> <m3fxi3ll1s.fsf@fleche.redhat.com> <3d6b0edb0903061044m2aa8671cn55940f43bc7db9a9@mail.gmail.com> <m3prfgjcy2.fsf@fleche.redhat.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Cc: gdb-patches@sourceware.org
> From: Tom Tromey <tromey@redhat.com>
> Date: Mon, 13 Apr 2009 18:28:37 -0600
>
> Tom> I don't know whether your FSF paperwork has gone through. I don't
> Tom> have a way to look that up any more; maybe someone else could find
> Tom> out.
>
> Abderrahim> Yes, I received the letter.
>
> Ok. The important bit for us is knowing when the FSF says that you
> are all set up.
I see that Abderrahim's name is already on file in the FSF copyright
assignments list.
> + TYPE_CODE (type =
> + check_typedef (TYPE_TARGET_TYPE (type))) == TYPE_CODE_STRUCT)
>
> GNU style prohibits embedded assignments like this.
Only inside an `if', which this one is not:
Try to avoid assignments inside `if'-conditions (assignments inside
`while'-conditions are ok). For example, don't write this:
if ((foo = (char *) malloc (sizeof *foo)) == 0)
fatal ("virtual memory exhausted");
instead, write this:
foo = (char *) malloc (sizeof *foo);
if (foo == 0)
fatal ("virtual memory exhausted");
That doesn't necessarily mean I'm opposed to Tom's comment, though:
unnecessary use of this style makes the source somewhat harder to
read.
> I know it is a pain, but this really needs test cases and
> documentation -- documentation for the users, and test cases so the
> gdb developers can test it occasionally. ("Occasionally" since I
> assume most of us won't have the vala compiler installed.)
I think such an important new feature will also need an entry for
NEWS.
Thanks.