This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Submit process record and replay fourth time, 7/8

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Sun, 22 Mar 2009 16:47:09 +0000
> 
> On Sunday 22 March 2009 16:43:36, Hui Zhu wrote:
> > About this part, I think it again. ?I think keep it to macro is
> > better. ?Because all of values can't be change. ?Set them to variable
> > just to make record linux code more friendly to other arch. ?So I
> > think make it to macro is more clear.
> 
> I don't think it's clearer at all.  I think it's just clutter.

For what it is worth, I agree with Pedro here.  If there is a bunch of
constants like this that are only used once, adding #defines for them
is a bit counterproductive.

Oh, and in one of the comments there is a space missing in Linux2.4.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]