This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: more missing gplv3 notices


On Wednesday 18 March 2009 15:46:31, Alfred M. Szmidt wrote:
> ? ?Sorry, I forgot I shouldn't talk about these things.
> 
> Though, to open a can of worms,
> 
> | ? ?It's important to name the changed function or variable in full.
> | Don't abbreviate function or variable names, and don't combine them.
> | Subsequent maintainers will often search for a function name to find all
> | the change log entries that pertain to it; if you abbreviate the name,
> | they won't find it when they search.
> | 
> | ? ?For example, some people are tempted to abbreviate groups of function
> | names by writing `* register.el ({insert,jump-to}-register)'; this is
> | not a good idea, since searching for `jump-to-register' or
> | `insert-register' would not find that entry.

And which part of:

        * Makefile.in, ada-exp.y, ada-lex.l, c-exp.y, cp-name-parser.y,
        darwin-nat-info.c, f-exp.y, gdb_thread_db.h, hppanbsd-nat.c,
        hppanbsd-tdep.c, hppaobsd-tdep.c, jv-exp.y, m2-exp.y, objc-exp.y,
        p-exp.y, reply_mig_hack.awk, reverse.c, xtensa-xtregs.c: Update
        license to GPLv3.

has any abbreviation, compared to:

        * Makefile.in: Update license to GPLv3.
        * ada-exp.y: Update license to GPLv3.
        * ada-lex.l: Update license to GPLv3.
...

?

I can't see the point you're making.

We should not abbreviate, since then grepping would miss the
abbreviated forms.  But I fail to see how the former form
has any disadvantage over the latter.  I certainly have used
the former form before many times, and it looks like I'm not the
only one.  Just try this to see for yourself:

>cd gdb
>grep "\.c," ChangeLog* 

?

I've grepped changelogs for changes to a file before, and never
before have I thought that I'd prefer people used the latter
form "'cause I was missing things".

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]