This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Fix MI timings


On Tuesday 17 March 2009 10:12:56 Vladimir Prus wrote:
> On Tuesday 17 March 2009 08:19:25 Pedro Alves wrote:
> > On Monday 09 March 2009 21:36:34, Pedro Alves wrote:
> > > On Monday 09 March 2009 21:32:25, Vladimir Prus wrote:
> > > > +void mi_print_timing_maybe ();
> > >
> > >                               ^ (void) here too, please.
> > >
> > > Also, it's redundant, but the only other function declared
> > > in the header marks it explicitly as "extern",  you may want
> > > to do the same for consistency.
> >
> > I was touching this file and noticed this patch went it without
> > the '(void)'.
>
> Guess what -- it was intentional -- based on IRC conversation where
> you have said (abridged) "C compiler does not really care for that word".

Oh, it was "void" that was missing? I only meant to not add "extern" :-(

Thanks for catching,
Volodya


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]