This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR exp/9103

From: Tom Tromey <tromey at redhat dot com>
To: Andre Oliveira Loureiro do Baixo <andreolb at gmail dot com>
Cc: gdb-patches at sourceware dot org
Date: Wed, 11 Mar 2009 11:08:41 -0600
Subject: Re: [PATCH] PR exp/9103
References: <c3f94bcc0903101928g3d767b7ah60ac81e8b6f77de@mail.gmail.com> <c3f94bcc0903110825n6e6b75e4j8c03f7f1a940b06c@mail.gmail.com> <20090311153711.GA5197@caradoc.them.org> <c3f94bcc0903110949j6161078bud54d3a5240b5ccd6@mail.gmail.com>
Reply-to: tromey at redhat dot com

>>>>> "Andre" == Andre Oliveira Loureiro do Baixo <andreolb@gmail.com> writes:

Andre> The patch works correctly because the function inside the modified
Andre> condition (val_print_string) scans the string using the size of each
Andre> character of the string. This size is passed to the function using the
Andre> parameter TYPE_LENGTH (elttype). Char * strings are printed by this
Andre> function, the only difference is that wchar_t* strings didn't get
Andre> inside the condition, and now they do.

Yeah, but it isn't as useful as it could be, because it doesn't
properly handle charset conversions.  Also, I suspect it won't work in
C, where wchar_t is a typedef.

Try this patch instead:

    http://sourceware.org/ml/gdb-patches/2009-01/msg00533.html

Tom

Follow-Ups:
- Re: [PATCH] PR exp/9103
  - From: Andre Oliveira Loureiro do Baixo

References:
- [PATCH] PR exp/9103
  - From: Andre Oliveira Loureiro do Baixo
- Re: [PATCH] PR exp/9103
  - From: Daniel Jacobowitz
- Re: [PATCH] PR exp/9103
  - From: Andre Oliveira Loureiro do Baixo

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]