This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Add _() to query
- From: Eli Zaretskii <eliz at gnu dot org>
- To: teawater <teawater at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 24 Feb 2009 20:52:04 +0200
- Subject: Re: [RFA] Add _() to query
- References: <daef60380902232310n32eb1f22m71265f0a38a952b1@mail.gmail.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Tue, 24 Feb 2009 15:10:51 +0800
> From: teawater <teawater@gmail.com>
>
> Hi Eli,
>
> I remember you told me that you want to add _() to all query.
> I make a patch for it. Do you think it's OK?
Yes, with the exception of a single comment below.
(I don't have an opinion regarding the _() vs --keyword approach to
marking translatable strings.)
> - if (from_tty && (!query ("%s", "")))
> + if (from_tty && (!query (_("%s"), "")))
AFAIK, it is absolutely pointless to mark for translation strings that
have no text, just formatted output conversion spec. That's because
the only translation of such strings is the string itself.