Re: [RFA] Darwin: recognize signal frames

[Tristan Gingold <gingold at adacore dot com>]

On Dec 10, 2008, at 12:03 PM, Joel Brobecker wrote:

> [Mark, I'd like to make i386_sigtramp_p non-static and use it here.
> Let me know if you think it's a bad idea... Thanks!]
>
> > 2008-12-05  Tristan Gingold  <gingold@adacore.com>
> >
> > 	* i386-darwin-tdep.c (darwin_sigtramp_p): New function.
> > 	(i386_darwin_sigcontext_addr): Ditto.
> > 	(amd64_darwin_sigcontext_addr): Ditto.
> > 	(darwin_dwarf_signal_frame_p): Ditto.
> > 	(i386_darwin_init_abi): Handle signal frames, use the const for
> > 	sc_num_regs.
> > 	(x86_darwin_init_abi_64): Ditto.
>
> After careful review and much discussion with Tristan, this is  
> mostly OK.

...

> > + static int
> > + darwin_sigtramp_p (struct frame_info *this_frame)
>
> This function is identical to i386-tdep.c:i386_sigtramp_p. I suggest
> we make i386_sigtramp_p non-static, add a declaration in i386-tdep.h,
> and then use that instead of having a second version here.

I have just committed this specific change as:

2009-02-04  Tristan Gingold  <gingold@adacore.com>

	* i386-tdep.c (i386_sigtramp_p): Make it public.
	* i386-tdep.h (i386_sigtramp_p): Declare.

Thanks,
Tristan.