This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Add la_getstr member to language_defn
- From: Tom Tromey <tromey at redhat dot com>
- To: Thiago Jung Bauermann <bauerman at br dot ibm dot com>
- Cc: Daniel Jacobowitz <drow at false dot org>, gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Mon, 02 Feb 2009 11:41:57 -0700
- Subject: Re: [RFA] Add la_getstr member to language_defn
- References: <1227417278.28256.183.camel@localhost.localdomain> <20081123161013.GA15069@caradoc.them.org> <1227490821.8533.25.camel@hotblack.bauerhaus> <20081124022858.GA19331@caradoc.them.org> <1227551659.28256.225.camel@localhost.localdomain> <20081124202146.GA1991@caradoc.them.org> <1227564549.28256.248.camel@localhost.localdomain> <1230949603.8380.143.camel@localhost.localdomain>
- Reply-to: tromey at redhat dot com
>>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:
[ la_getstr ]
Thiago> The patch doesn't apply anymore. This is the same patch, refreshed
Thiago> against HEAD as of Dec 28th.
Thiago> + Return 0 on success, errno on failure. */
Thiago> +
Thiago> +static int
Thiago> +c_get_string (struct value *value, gdb_byte **buffer, int *length,
Thiago> + const char **charset)
The return value here is a bit funny. For some errors this function
calls error, but for others it returns the result of read_string.
When would we want the latter behavior? I think perhaps la_getstr
should simply have 'void' type and then call error if read_string
returns an error.
What do you think?
Otherwise, this patch seems good to me. I'm not completely
comfortable approving it outright; but if there are no objections
after a week or so, I will.
Tom