This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] amd64 displaced stepping support


On Wednesday 28 January 2009 08:39:47, Doug Evans wrote:
> I'd like to add the needed interfaces. ?I'm just not sure how long a
> process that will be and I'd like to get started on exercising amd64
> non-stop functionality. ?I'll pursue exporting the modrm_bytes arrays
> and insn-length computation with binutils.

Ok, thanks a lot.  I don't think doing that should be a prerequisite
for this patch.  I just wanted to know if it's in your radar, and in case
it was not, to have it recorded somewhere as a TODO item.

> Ok to check in?

Looks great to me.

> [Modulo I need to clear the opcode/i386.h additions with binutils.
> I'm not sure who to get approval from first.]

The gdb bits are approved.  A suggestion: don't add the macros/defines you
were adding in opcode/i386.h just yet, but inline / add them in amd64-tdep.c,
and check in the gdb patch (pre-approved).  Then, all the opcode changes
can be made on top, separately (and incrementally, if desired).  Sounds
good to you?

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]