Re: [PATCH 4/4] catch syscall -- try 4 -- Build system, testcase and documentation

[Sérgio Durigan Júnior <sergiodj at linux dot vnet dot ibm dot com>]

Hi Eli,

On Mon, 2009-01-26 at 06:01 +0200, Eli Zaretskii wrote:

> > +Catchpoint 1 (call to syscall 'chroot'), 0xffffe424 in __kernel_vsyscall ()
> 
> This line (and others similar to it) is too long for @smallexample, it
> will certainly overflow the page margin.  Please break these long
> lines in two.  The rule is to have at most 74 characters inside
> @smallexample blocks.

Thanks, I fixed it.

> > +If you configure @value{GDBN} using the @samp{--without-expat} option,
> > +it will not be able to display syscall names.  Also, if your
> > +architecture does not have an XML file describing its system calls,
> > +you will not be able to see the syscall names.
> 
> It would be good to add here a sentence saying that these two features
> are used for accessing the syscall name database.  It might be obvious
> for you, but a Joe Random Hacker may not immediately realize that
> catching syscalls has any relation to XML and expat.

Hmm, good observation. I'd like to know if this is good enough:

If you configure @value{GDBN} using the @samp{--without-expat} option,
it will not be able to display syscall names.  Also, if your
architecture does not have an XML file describing its system calls,
you will not be able to see the syscall names.  It is important to
not that these two features are used for accessing the syscall
name database.  In either case, you will see a warning like this:
...

What do you think?

> What about a NEWS entry?

Good idea. I'll send it ASAP.

Thanks,

-- 
Sérgio Durigan Júnior
Linux on Power Toolchain - Software Engineer
Linux Technology Center - LTC
IBM Brazil