This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Don't use builtin_long() when ptrdiff_t is needed in gnu-v3-abi.c

On Sun, 7 Dec 2008 15:14:07 -0500
Daniel Jacobowitz <drow@false.org> wrote:

> On Thu, Dec 04, 2008 at 09:22:51PM -0700, Kevin Buettner wrote:
> > This patch remedies this situation by using the same ptrdiff_t type
> > as that used in the construction of the vtable type.
> > 
> > Okay?
> 
> This makes sense to me; thanks for fixing it.
> 
> > +  /* The "offset_to_top" field has the appropriate (ptrdiff_t) type.  */
> > +  return TYPE_FIELD_TYPE(vtable_type, vtable_field_offset_to_top);
> 
> Space before paren, btw.

Thanks for reviewing my patch.

I've committed this patch, after adding the missing space noted above.

Kevin
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]