This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/Ada] remove ref to fields and ref to slices


> Not really. ada_value_slice already exists: same function, but it works
> on array. ada_value_slice_ptr, at the contrary, works on pointers to
> array or references. Maybe ada_value_slice_from_ptr would be clearer?

Rats! I'm looking at the code, and I am thinking that there is a bit
of simplification that we could look at, now that the contents of lazy
values is allocated later. For instance:

ada_coerce_to_simple_array_ptr vs ada_coerce_to_simple_array

If we got rid of ada_coerce_to_simple_array_ptr, then we probably
wouldn't need ada_value_slice_ptr..

But in the meantime, I do think that ada_value_slice_from_ptr is
clearer.

Thanks,
-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]