This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/commit] pre-initialize python-value.c:values_in_python (bug in MacOS linker)
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: brobecker at adacore dot com
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 6 Dec 2008 16:29:50 +0100 (CET)
- Subject: Re: [RFA/commit] pre-initialize python-value.c:values_in_python (bug in MacOS linker)
- References: <20081205184123.GF5382@adacore.com>
> Date: Fri, 5 Dec 2008 19:41:23 +0100
> From: Joel Brobecker <brobecker@adacore.com>
>
> Hello,
>
> We noticed that GDB does not build on x86-macos and x86_64-macos when
> configured --without-python (we found this out because one of our
> machine no longer has python installed on it). The problem is that
> the linker complains that it cannot file values_in_python, referenced
> from value.c. This is a bug, since we verified that the symbol was
> defined inside python-value.o which was also part of the archive.
> We think that this might be related to the fact that the symbol is
> defined as "C" (common). We changed the code to add an initial value
> of NULL (which in C is strictly equivalent to the current code),
> which changed our variable to the Data section and, ta da, allowed
> GDB to link.
>
> 2008-12-05 Joel Brobecker <brobecker@adacore.com>
>
> * python/python-value.c (values_in_python): Add specific initialization
> to NULL to work-around a MacOS linker bug.
>
> Tested on x86-linux, both using --with-python and --without-python.
> No regression.
>
> I think this is pretty safe and safe contained, and doesn't reduce
> the quality of the code, so I'm planning on committing this on Monday
> when back from weekend holiday (I'm in Europe). Any objection? Should
> I add a comment?
Ugh, Yuck. Any idea if this is fixed in more recent versions of Mac OS X?