This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Thanks, Daniel, for the thorough review. I was only hoping for a quick look at the principle, so thanks again. Here is a new version of the patch, with all corrections made, including a typo in a comment that Pedro noticed and emailed me about. I was going to check it in, but I re-ran the testsuite, and this time, I'm having unexpected timeouts in multi-forks.exp. Bad luck, something personal came up, and I won't have time to look further into this. > So, Daniel already reviewed your patch :-). As my rework on catch > syscall heavily depends on your patch, I'm waiting until it gets pushed > upstream so that I can start to modify things here. So, Sergio, here is what I'm proposing: If you are in a hurry, then can you investigate the reason for the regressions? It shouldn't be too difficult. Once fixed and approved, you can then start building your patch on top of mine. If you're not in a hurry, then I'll pick it up again when I have some free time again. 2008-10-14 Joel Brobecker <brobecker@adacore.com> * breakpoint.h (enum bptype): New enum bp_catchpoint. Delete bp_catch_fork and bp_catch_vfork. (struct breakpoint_ops): Add new methods "insert", "remove" and "breakpoint_hit". * breakpoint.c (create_fork_vfork_event_catchpoint) (create_fork_event_catchpoint, create_vfork_event_catchpoint): Remove. (insert_catchpoint): Remove handling of bp_catch_fork and bp_catch_vfork catchpoints, and handle them as bp_catchpoint catchpoints instead. (insert_bp_location, update_breakpoints_after_exec) (remove_breakpoint, bpstat_check_location, bpstat_what) (allocate_bp_location): Likewise. (print_it_typical, print_one_breakpoint_location, mention): Remove handling of bp_catch_fork and bp_catch_vfork breakpoints. (ep_is_catchpoint, user_settable_breakpoint) (breakpoint_address_is_meaningful, adjust_breakpoint_address) (breakpoint_re_set_one, disable_command, enable_command): Remove use of bp_catch_fork and bp_catch_vfork. Add handling of bp_catchpoint breakpoints. (insert_catch_fork, remove_catch_fork, breakpoint_hit_catch_fork) (print_it_catch_fork, print_one_catch_fork, print_mention_catch_fork): New functions. (catch_fork_breakpoint_ops): New static constant. (insert_catch_vfork, remove_catch_vfork, breakpoint_hit_catch_vfork) (print_it_catch_vfork, print_one_catch_vfork) (print_mention_catch_vfork): New functions. (catch_vfork_breakpoint_ops): New static constant. (create_catchpoint, create_fork_vfork_event_catchpoint): New functions. (catch_fork_command_1): Use create_fork_vfork_event_catchpoint to create the fork and vfork catchpoints. (gnu_v3_exception_catchpoint_ops): Set new breakpoint_ops fields. * ada-lang.c (catch_exception_breakpoint_ops): Set new breakpoint_ops fields. (catch_exception_unhandled_breakpoint_ops): Likewise. (catch_assert_breakpoint_ops): Likewise. 2008-10-06 Joel Brobecker <brobecker@adacore.com> * gdb.base/foll-fork.exp: Adjust the expected output to match the new description for fork/vfork catchpoints in the "info breakpoints" output. Cheers, -- Joel
Attachment:
catchpoint.diff
Description: Text document
Attachment:
catchpoint-ex.diff
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |