This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Reverse Debugging, 3/5


HaaaAAAAA, thank you so much for the example, it makes complete sense now.
If you don't mind, and that's only a suggestion, perhaps I would suggest
handle_stepped_backward_into_function for the function name.

> Hmmm.  Well, the question is, do we need to update stop_func_start.
> We don't use it locally, so perhaps we don't need to do it.  But
> I don't really know if we're doing it because someone else will
> maybe need it later.
> 
> It might be an artifact.  But it's not "incorrect", in that
> skipping the prologue is the right thing to do IF you want
> the function start location.

Hmm, you might be right. I'm young and foolish, so I tend to delete code
I'm not sure I need, and only put it back when things do actually break.
I looked at the "handle_inferior_event" code, and it looks like this
field is not used before being recomputed, but it's hard to say for
sure, as you have to also visit the functions being called from there...
Anyway, I was just wondering...

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]