This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Reverse Debugging, 1/5


Joel Brobecker wrote:
Before I actually implement this, let me see if we're all
on the same page (Daniel, Joel, Pedro...)

My own view was a little simpler: Delete the target_set_execdir method,

I'm guessing you meant "get" here?


and replace all the calls with a reference to the infrun global. I would
keep the target_set_execdir more or less as is; otherwise, you'll need
some kind of observer to notice when the execdir changes. The
"to_can_go_backwards" is an interesting idea, but in my opinion only
makes sense if the target_set_execdir method is removed.  Otherwise,
we can treat target_set_execdir == NULL as cannot-go-backwards.

OK, so you're saying that "target_set_execdir" will set the global infrun variable, not a target-defined variable?

I would have thought somebody would object to that on semantic grounds.

Then the only reason to put it into the target vector is so that
we can check for "cannot-go-backwards", and surely someone will
come back and tell me "well that is what you should call it then".


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]