This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Reverse Debugging, 4/5
- From: Tom Tromey <tromey at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Michael Snyder <msnyder at vmware dot com>, "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>, Daniel Jacobowitz <drow at false dot org>, Pedro Alves <pedro at codesourcery dot com>, teawater <teawater at gmail dot com>
- Date: Mon, 06 Oct 2008 16:35:27 -0600
- Subject: Re: [RFA] Reverse Debugging, 4/5
- References: <48E3CD40.3070206@vmware.com> <20081006215637.GE21853@adacore.com>
- Reply-to: tromey at redhat dot com
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Michael> +void
Michael> +breakpoint_silence (struct breakpoint *b)
Michael> +{
Michael> + /* Silence the breakpoint. */
Michael> + b->silent = 1;
Joel> Minor nit: This name brings little meaning when I see it being called.
Joel> Can we change it to "make_breakpoint_silent"? That way, the comment
Joel> in the body becomes useless and can be removed.
The Python breakpoint wrapper directly sets or clears b->silent.
Perhaps we could make this a generic setter in anticipation of that
patch?
Tom