This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA record/replay] cast to avoid compiler warning

From: Andreas Schwab <schwab at suse dot de>
To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
Cc: msnyder at vmware dot com, gdb-patches at sourceware dot org, teawater at gmail dot com
Date: Sun, 05 Oct 2008 09:11:27 +0200
Subject: Re: [RFA record/replay] cast to avoid compiler warning
References: <48E7B927.9050207@vmware.com> <200810042152.m94LqN1R018675@brahms.sibelius.xs4all.nl>

Mark Kettenis <mark.kettenis@xs4all.nl> writes:

>> Date: Sat, 04 Oct 2008 11:42:47 -0700
>> From: Michael Snyder <msnyder@vmware.com>
>> 
>> Sizeof returns size_t, which is not always the same as int.
>> This cast will prevent compiler warnings on some architectures
>> (eg. x86_64)
>
> This is wrong!  Better cast to unsigned long and print as %lu.

The value will always be a small number.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Follow-Ups:
- Re: [RFA record/replay] cast to avoid compiler warning
  - From: Mark Kettenis

References:
- [RFA record/replay] cast to avoid compiler warning
  - From: Michael Snyder
- Re: [RFA record/replay] cast to avoid compiler warning
  - From: Mark Kettenis

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]