This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Patch] Fix 'incomplete type' warning in dummy_frame.h


Back on 2008-08-26, Ulrich Weigand added a declaration for
dummy_frame_pop to dummy_frame.h.  This causes a fatal warning when I
build with gcc-3.4 targeting mipsel-linux-gnu because struct frame_id is
an incomplete type.

Adding #include "frame.h" fixes the problem for me.

I'm don'e think I have write access to gdb (I do have it in binutils),
so if it is OK, someone will either have to commit it or turn on write
access for me.

2008-09-07  David Daney  <ddaney@avtrex.com>

	* dummy-frame.h (frame.h): Include it.
	(struct frame_id): Remove declaration.

Index: dummy-frame.h
===================================================================
RCS file: /cvs/src/src/gdb/dummy-frame.h,v
retrieving revision 1.22
diff -u -p -r1.22 dummy-frame.h
--- dummy-frame.h	26 Aug 2008 17:40:24 -0000	1.22
+++ dummy-frame.h	8 Sep 2008 00:43:01 -0000
@@ -20,10 +20,10 @@
 #if !defined (DUMMY_FRAME_H)
 #define DUMMY_FRAME_H 1
 
+#include "frame.h"
 struct frame_info;
 struct regcache;
 struct frame_unwind;
-struct frame_id;
 
 /* Push the information needed to identify, and unwind from, a dummy
    frame onto the dummy frame stack.  */

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]