This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc] add ppc testcase to test fpscr


> 2008-09-03  Thiago Jung Bauermann  <bauerman@br.ibm.com>
> 
> 	* gdb.arch/ppc-fp.exp: New file.
> 	* gdb.arch/ppc-fp.c: New file.

This looks good to me. Just a question:

On a couple of occasions, you use the "verbose" routine, and then
call it again with the same argument, except for the -log:

> +    verbose "Skipping powerpc floating point register tests."
> +    verbose -log "Skipping powerpc floating point register tests."

I searched throughout the gdb.base directory, and I found only uses
of verbose without -log. In testsuite/lib, I saw uses of both forms,
but never at the same time...

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]