This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: shrink main_type

On Tue, Aug 19, 2008 at 12:17:01AM +0200, Andreas Schwab wrote:
> Tom Tromey <tromey@redhat.com> writes:
> 
> > +  /* Copy the common fields of types.  For the main type, we simply
> > +     copy the entire thing and then update specific fields as needed.  */
> > +  memcpy (TYPE_MAIN_TYPE (new_type), TYPE_MAIN_TYPE (type),
> > +	  sizeof (struct main_type));
> 
> IMHO this should be written as an assignment.

I think it's equally clear this way...

-- 
Daniel Jacobowitz
CodeSourcery
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]