Re: [RFC][patch 1/9] initial Python support

[Thiago Jung Bauermann <bauerman at br dot ibm dot com>]

On Sun, 2008-07-06 at 11:27 -0600, Tom Tromey wrote:
> >>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:
> 
> >>> > +  if (PyErr_Occurred ())
> >>> > +    {
> >>> > +      PyErr_Print ();
> >>> > +      error ("error while executing Python code");
> >>> > +    }
> >>> > +}
> 
> Thiago> This is stillpending, I think.
> 
> FYI -- I fixed this today.  I added a new 'maint set python-stack'
> variable that controls whether Python stack traces are printed.  By
> default they are.  I changed all the new code to use a new
> gdbpy_print_stack which checks this variable.  Finally, I set things
> up so that gdb overrides Python's sys.stdout and sys.stderr to print
> things using printf_filtered.

Awesome!
This means that there are only three things pending for this patch to go
in:

1. I'd like someone to verify if my call to bpstat_do_actions in
execute_gdb_command is needed and if I implemented it correctly (I'm not
sure I knew what I was doing, I just wanted something there so I could
post the patch).

2. Testcases
3. Documentation (both user and internal)

I can work on the last two items, but I'd like input on the first. After
these are resolved I'll post a refreshed patch to the list.
-- 
[]'s
Thiago Jung Bauermann
Software Engineer
IBM Linux Technology Center