This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Add comments to linux-nat.c
- From: Daniel Jacobowitz <drow at false dot org>
- To: Vladimir Prus <vladimir at codesourcery dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Thu, 26 Jun 2008 09:51:49 -0400
- Subject: Re: [RFA] Add comments to linux-nat.c
- References: <200806141829.05646.vladimir@codesourcery.com>
On Sat, Jun 14, 2008 at 06:29:05PM +0400, Vladimir Prus wrote:
>
> With the introduction of async mode, linux-nat.c became even more complex that it
> was, and it became apparent that some high-level comments are needed. So, I've grabbed
> Pedro and Dan on IRC and extracted the knowledge from their heads into a text file.
> Here's the result. OK?
When you get a chance, could you repost this with Eli's comments
addressed? Here's a few more but the content looks fine.
> +/* This comments documents high-level logic of this file.
This comment documents the, or These comments document the.
> +blocked, the signal becomes pending and sigsuspend, presumably, immediately
> +noticed it and returns.
s/presumably, //. You're correct. Also noticed -> notices.
> +The main design point is that every time GDB is outside linux-nat.c, we have a
> +SIGCLD handler installed that is called when something happens to the target
SIGCHLD
--
Daniel Jacobowitz
CodeSourcery