This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [non-stop] 01/10 Add "executing" property
Daniel Jacobowitz wrote:
> On Tue, Jun 17, 2008 at 07:24:04PM +0100, Pedro Alves wrote:
>> @@ -422,7 +417,10 @@ execute_command (char *p, int from_tty)
>>
>> /* If the target is running, we allow only a limited set of
>> commands. */
>> - if (target_can_async_p () && target_executing && !get_cmd_async_ok (c))
>> + if (target_can_async_p ()
>> + && target_has_execution
>> + && any_running ()
>> + && !get_cmd_async_ok (c))
>> error (_("Cannot execute this command while the target is running."));
>>
>> /* Pass null arg rather than an empty one. */
>
> Don't need target_has_execution here anymore, do we?
>
> The patch otherwise looks OK.
>
> Before we start checking these in, how do you plan to handle
> documentation (internals also, but mostly user) and test cases?
Test cases are on my plate, FWIW, as well as MI docs. I'm not sure
if there's general docs to be written, and I'm not not sure about
internals docs.
- Volodya