This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commit] Robustify mi-simplerun.


On Saturday 14 June 2008 00:00:35 Daniel Jacobowitz wrote:
> On Fri, Jun 13, 2008 at 11:55:42PM +0400, Vladimir Prus wrote:
> > The program been run by this testcase produces output.  Since GDB prints
> > the *running notification, and the prompt, after actually resuming the program,
> > there's a race condition -- the program may produce the output before gdb prints
> > the prompt, which breaks the test.  This patch add artificial delay to the 
> > program to make sure gdb print the prompt first.
> 
> Is the output necessary for any test?  If not, can we just remove it?
> Sleep is bad.  Someone'll run the testsuite on a machine with load
> (e.g. our nightly tester) and it'll fail again.

I cannot find any evidence that the output is directly tested for. There are
some tests that rely on the presence of the code statements that produce
this output, so just removing those prints will be more work.

Do you actually think high load will break this? Essentially, we only need
gdb to grab a single slice of processor time before the debugged program gets to
printing, and I'd expect it will, during that second.

- Volodya


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]