This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: fix two field name completion bugs


On Sun, Jun 08, 2008 at 12:41:28PM -0600, Tom Tromey wrote:
> ChangeLog:
> 2008-06-08  Tom Tromey  <tromey@redhat.com>
> 
> 	* completer.c (complete_line): Don't special-case
> 	expression_completer.
> 	(expression_completer): Only pass last word to
> 	location_completer.
> 	* c-exp.y (yylex): Check 'token', not 'operator'.

This part is OK.

> +send_gdb "p values\[0\] . a\t"
> +sleep 3
> +gdb_expect  {

I know there's other tests in completion.exp that do this but are the
sleeps really necessary?  Anywhere that we sleep, the testsuite
becomes timing sensitive - not to mention slow.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]