This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] CR16 target simulator specific patch


On Fri, May 02, 2008 at 05:00:29PM +0530, M R Swami Reddy wrote:
> Hello,
>
> Updated CR16 target specific machine code decoding algorithm using hash 
> table and added a few test cases to testsuite/sim/cr16 directory.
> Please find the attached patch for the above changes.

You're the maintainer of the CR16 simulator.  That means that you
don't need approval to commit changes in sim/cr16.  I can't usefully
review them since I don't know anything about CR16.

I have one small comment though: please do not comment out code.
If it's wrong or obsolete, delete it.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]