This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] 2/3: Fix crash on self-looping DW_OP_fbreg
- From: Daniel Jacobowitz <drow at false dot org>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 1 May 2008 16:29:04 -0400
- Subject: Re: [patch] 2/3: Fix crash on self-looping DW_OP_fbreg
- References: <20080428083732.GB12394@host0.dyn.jankratochvil.net>
On Mon, Apr 28, 2008 at 10:37:32AM +0200, Jan Kratochvil wrote:
> 2008-04-28 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * Makefile.in: Update dependencies.
> * dwarf2expr.c: New include "gdb_assert.h".
> (new_dwarf_expr_context): Initialize MAX_RECURSION_DEPTH.
> (struct dwarf_expr_eval_cleanup, dwarf_expr_eval_cleanup): New.
> (dwarf_expr_eval): Protect the RECURSION_DEPTH count for exceptions.
> (execute_stack_op): Error out on too large RECURSION_DEPTH.
> Increase/decrease RECURSION_DEPTH around the function.
OK. Do we need a cleanup for this though? If we error out, we won't
get back until we create a new context, so missing the decrement
is not a problem.
--
Daniel Jacobowitz
CodeSourcery