This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] mixed source+assembly from cli disassemble
On Thu, Apr 17, 2008 at 02:25:19PM -0700, Joel Brobecker wrote:
> > + if (*arg == '\0')
> > + error (_("Missing modifier."));
> > +
> > + while (*arg && ! isspace (*arg))
> > + {
> > + switch (*arg++)
> > + {
> > + case 'm':
> > + mixed_source_and_assembly = 1;
> > + break;
> > + default:
> > + error (_("Invalid disassembly modifier."));
> > + }
> > + }
> > +
> > + while (isspace (*arg))
> > + ++arg;
>
> The formatting looks weird, because some of the lines (the "while" lines
> for instance) are using spaces instead of tabs. Could you fix that to
> use TABs, please?
It looks right to me. It just gets weirder and weirder as you add
more levels of email quoting.
--
Daniel Jacobowitz
CodeSourcery