This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gdb.base/break.exp: Mark failures as such


On Fri, Mar 28, 2008 at 04:32:00PM +0000, Maciej W. Rozycki wrote:
> Hello,
> 
>  A few tests in gdb.base/break.exp incorrectly flag their catch-all 
> pattern as a success.  Here is a fix, including some reformatting which 
> actually makes makes them readable (the current opposite state probably 
> being responsible for the problem).
> 
> 2008-03-28  Maciej W. Rozycki  <macro@mips.com>
> 
> 	* gdb.base/break.exp: Mark failures as such.  Fix formatting.
> 
>  Almost obvious, but just in case: OK to apply?

OK.

> +    -re ".*$gdb_prompt $" {
> +	fail "Temporary breakpoint line number #1"
> +    }
> +    timeout {
> +	fail "breakpoint line number #1 (timeout)"
> +    }

Could you fix the test name in the timeout fail, too?


-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]