This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Async mode fixes.
> Likewise, I think it's better to always use async mode,
> if the target supports it. We're not at the point when we can do
> it -- even with my patch, 'target async' has a couple of extra
> failures relatively to 'target remote', and I never tried getting
> test results for linux native -- but I think having async mode
> always on should be end goal.
The patch isn't perfect, e.g., you say:
I get the following with my patch:
(gdb)
-interpreter-exec console continue
~"Continuing.\n"
^running
*stopped,reason="breakpoint-hit",bkptno="1",thread-id="1",.....
but that should be:
(gdb)
-interpreter-exec console continue
~"Continuing.\n"
^running
(gdb)
*stopped,reason="breakpoint-hit",bkptno="1",thread-id="1",.....
because in mi_execute_command, args.action == EXECUTE_COMMAND_SUPRESS_PROMPT
when it should be EXECUTE_COMMAND_DISPLAY_PROMPT. This in turn is because
sync_execution is 1 when it should be 0. Note that in Apple's code
sync_execution doesn't get toggled by async_enable/disable_stdin,
but, if Daniel is prepared to approve it, I would suggest committing it on
the trunk as there is plenty of time to polish it and it breaks things into
manageable chunks.
Then, at some stage, I could repost my patch as a much smaller diff and with
further improvements.
--
Nick http://www.inet.net.nz/~nickrob