This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: 'show args' -vs- '--args'


>>>>> "Daniel" == Daniel Jacobowitz <drow@false.org> writes:

Daniel> Anyway, now that it's a show_func...

>> +notice_args_read (struct cmd_list_element *c)
>> {
>> -  deprecated_show_value_hack (file, from_tty, c, value);
>> /* Might compute the value.  */
>> get_inferior_args ();
>> }

Daniel> wouldn't just swapping those two function calls fix it?

I suppose it could if we did this:

   deprecated_show_value_hack (file, from_tty, c, get_inferior_args ());

i.e., we didn't print the passed-in value -- that value is already
known to be wrong.

It seems a little weird to do this, given that this function is named
'deprecated_...', and given that there is an existing hook that does
exactly what is needed here.  That aid I'm happy to resubmit a patch
based on this idea if that is what you want, just let me know.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]