This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC/RFA] continue stepping if landed in new range of same line


On Sat, Dec 22, 2007 at 10:01:37AM +0400, Joel Brobecker wrote:
> I wouldn't mind removing the code altogether; as a bonus it would also
> reduce the size of handle_inferior_event. I can send a patch now, or
> I can poll users on gdb@ and see what they think... Honestly, given
> the likeliness of one-line functions, I'd just say it's not very
> important to keep that special case.

There are a few one line functions in the testsuite.  In my opinion /
experience, they cover all the cases that really need to be covered;
if we find an omission, we can add some more tests :-)

> 2007-12-22  Joel Brobecker  <brobecker@adacore.com>
> 
>         * infrun.c (handle_inferior_event): Remove code that made us
>         stop when stepping into the last line of the current function.
> 
> Tested on x86-linux, no regression.

This is OK as far as I'm concerned.  And I am always in favor of
simplifying handle_inferior_event.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]