This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: mips-tdep.c: Sign-extend pointers for n32
- From: Daniel Jacobowitz <drow at false dot org>
- To: "Maciej W. Rozycki" <macro at mips dot com>
- Cc: gdb-patches at sourceware dot org, David Ung <davidu at mips dot com>, "Maciej W. Rozycki" <macro at linux-mips dot org>
- Date: Sun, 16 Dec 2007 13:46:25 -0500
- Subject: Re: mips-tdep.c: Sign-extend pointers for n32
- References: <Pine.LNX.4.61.0710251443260.22756@perivale.mips.com>
On Thu, Oct 25, 2007 at 03:10:20PM +0100, Maciej W. Rozycki wrote:
> 2007-10-25 David Ung <davidu@mips.com>
>
> * mips-tdep.c (mips_n32n64_push_dummy_call): Sign-extend the
> pointer value if the length of the variable is less than the
> width of the register size of the ABI.
>
> OK to apply?
Why just pointers? I'm not entirely sure what's going on above in the
float case, but in the integer case this seems clearly wrong. Zero
extension is probably "right" for trailing bits of structures but what
about negative integers?
--
Daniel Jacobowitz
CodeSourcery